Repository navigation
Expose one-pass labelled choice enumeration - #27
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enumerate labels and values together
P181 introduced an N-squared dropdown path: ChoicesEditor asked for every label separately, and AdvertisedChoices rebuilt/scanned the whole advertisement for each label.
AnnotationChoices now supplies a one-pass labelled_choices boundary for generic consumers. LabelledChoices supplies inherited value/label operations for sources that already own paired data; Toad's advertisement metadata implements only that original pair enumeration. The shared editor consumes the pairs directly, with no second registry or cache. Reverse-label decoding also enumerates once.
Native application and source review; one direct SDK-advertisement check covers pair order, values, labels and reverse lookup. No suite or profiling. Paired python-introspect and Toad source changes ship together through the ordinary tracked-main installer.